forked from kay/RouterOS
Diagramm-Fixes: echter Geometrie-Bug behoben (VLAN-/Bridge-Port-Kanten laufen innerhalb derselben Spalte, eine Firewall/NAT-Kante rückwärts — die Kurven-Berechnung nahm immer "rechts raus, links rein" an und schoss dabei über den Canvas hinaus, links abgeschnitten). Hover-Flackern durch Trägheit + Beschränkung auf hervorgehobene Kanten behoben. Klick-vs- Hover-Priorität vertauscht (Klick gewinnt jetzt über Hover, vorher verdrängte das Streifen fremder Karten beim Nachfahren einer Linie die Auswahl). Linien-Klick zeigt jetzt volle Erklärung im rechten Panel (EdgeDetailView) statt nur Hover-Tooltip. Ein Auto-Fit-Versuch (GeometryReader) brach das Scroll-Verhalten und wurde wieder zurückgezogen. Neue Fähigkeit: ein Knoten (IP-Adresse, Pool, DHCP-Server/-Netzwerk/ -Client, Route, Firewall-Filter-/NAT-Regel, WireGuard-Peer) lässt sich direkt über denselben Dialog wie im Experte-Tab bearbeiten und zurückschreiben (OverviewNode.EditTarget + wiederverwendete ExpertItemEditView). Live bestätigt: Kommentar-Änderung an einer Firewall-Regel. 59 Unit-Tests grün. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDmUd93KxsYGr2kLTotWnG
139 lines
7.2 KiB
Swift
139 lines
7.2 KiB
Swift
import XCTest
|
|
@testable import RouterOSAssistant
|
|
|
|
final class OverviewGraphTests: XCTestCase {
|
|
private func item(_ fields: [String: String], id: String = "*1") -> RouterOSMenuItem {
|
|
RouterOSMenuItem(id: id, fields: fields)
|
|
}
|
|
|
|
func testInterfaceToIPAddressEdge() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [item(["name": "ether1", "type": "ether"])],
|
|
bridgePorts: [], vlans: [], wireguardPeers: [],
|
|
addresses: [item(["address": "192.168.88.1/24", "interface": "ether1", "network": "192.168.88.0"])],
|
|
pools: [], dhcpServers: [], dhcpNetworks: [], dhcpClients: [], routes: [],
|
|
filterRules: [], natRules: [], addressLists: []
|
|
)
|
|
|
|
XCTAssertTrue(graph.nodes.contains { $0.id == "Interfaces:ether1" })
|
|
XCTAssertTrue(graph.nodes.contains { $0.id == "IP-Adressen:192.168.88.1/24" })
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Interfaces:ether1" && $0.to == "IP-Adressen:192.168.88.1/24" })
|
|
}
|
|
|
|
func testVlanEdgeToParentInterface() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [
|
|
item(["name": "ether5", "type": "ether"]),
|
|
item(["name": "vlan20", "type": "vlan"])
|
|
],
|
|
bridgePorts: [],
|
|
vlans: [item(["name": "vlan20", "vlan-id": "20", "interface": "ether5"])],
|
|
wireguardPeers: [], addresses: [], pools: [], dhcpServers: [], dhcpNetworks: [],
|
|
dhcpClients: [], routes: [], filterRules: [], natRules: [], addressLists: []
|
|
)
|
|
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Interfaces:ether5" && $0.to == "Interfaces:vlan20" })
|
|
let vlanNode = graph.nodes.first { $0.id == "Interfaces:vlan20" }
|
|
XCTAssertEqual(vlanNode?.subtitle, "VLAN 20")
|
|
}
|
|
|
|
func testDhcpServerEdgesToInterfaceAndPool() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [item(["name": "ether2", "type": "ether"])],
|
|
bridgePorts: [], vlans: [], wireguardPeers: [], addresses: [],
|
|
pools: [item(["name": "pool1", "ranges": "192.168.88.10-192.168.88.254"])],
|
|
dhcpServers: [item(["name": "dhcp1", "interface": "ether2", "address-pool": "pool1"])],
|
|
dhcpNetworks: [], dhcpClients: [], routes: [], filterRules: [], natRules: [], addressLists: []
|
|
)
|
|
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Interfaces:ether2" && $0.to == "Pools & DHCP:dhcp:dhcp1" })
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Pools & DHCP:dhcp:dhcp1" && $0.to == "Pools & DHCP:pool:pool1" })
|
|
}
|
|
|
|
func testDhcpNetworkLinksViaAddressNetworkField() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [item(["name": "ether2", "type": "ether"])],
|
|
bridgePorts: [], vlans: [], wireguardPeers: [],
|
|
addresses: [item(["address": "192.168.88.1/24", "interface": "ether2", "network": "192.168.88.0"])],
|
|
pools: [], dhcpServers: [],
|
|
dhcpNetworks: [item(["address": "192.168.88.0/24", "gateway": "192.168.88.1"])],
|
|
dhcpClients: [], routes: [], filterRules: [], natRules: [], addressLists: []
|
|
)
|
|
|
|
XCTAssertTrue(graph.edges.contains {
|
|
$0.from == "IP-Adressen:192.168.88.1/24" && $0.to == "Pools & DHCP:dhcpnet:192.168.88.0/24"
|
|
})
|
|
}
|
|
|
|
func testRouteLinksToInterfaceOnlyWhenGatewayIsAnInterfaceName() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [item(["name": "ether1", "type": "ether"])],
|
|
bridgePorts: [], vlans: [], wireguardPeers: [], addresses: [], pools: [],
|
|
dhcpServers: [], dhcpNetworks: [], dhcpClients: [],
|
|
routes: [
|
|
item(["dst-address": "0.0.0.0/0", "gateway": "ether1"]),
|
|
item(["dst-address": "10.0.0.0/24", "gateway": "192.168.88.254"])
|
|
],
|
|
filterRules: [], natRules: [], addressLists: []
|
|
)
|
|
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Interfaces:ether1" && $0.to == "route:0" })
|
|
XCTAssertFalse(graph.edges.contains { $0.to == "route:1" })
|
|
}
|
|
|
|
func testFirewallFilterEdgesToInterfacesAndAddressList() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [
|
|
item(["name": "ether1", "type": "ether"]),
|
|
item(["name": "ether2", "type": "ether"])
|
|
],
|
|
bridgePorts: [], vlans: [], wireguardPeers: [], addresses: [], pools: [],
|
|
dhcpServers: [], dhcpNetworks: [], dhcpClients: [], routes: [],
|
|
filterRules: [item([
|
|
"chain": "forward", "action": "drop",
|
|
"in-interface": "ether1", "out-interface": "ether2",
|
|
"src-address-list": "gesperrt"
|
|
])],
|
|
natRules: [],
|
|
addressLists: [item(["list": "gesperrt", "address": "10.0.0.5"])]
|
|
)
|
|
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Interfaces:ether1" && $0.to == "filter:0" })
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "filter:0" && $0.to == "Interfaces:ether2" })
|
|
XCTAssertTrue(graph.edges.contains { $0.from == "Firewall & NAT:addrlist:gesperrt" && $0.to == "filter:0" })
|
|
}
|
|
|
|
func testEditableNodesCarryTheirRouterOSMenuAndItemID() {
|
|
let graph = OverviewViewModel.buildGraph(
|
|
interfaces: [item(["name": "ether1", "type": "ether"])],
|
|
bridgePorts: [], vlans: [], wireguardPeers: [],
|
|
addresses: [item(["address": "192.168.88.1/24", "interface": "ether1", "network": "192.168.88.0"], id: "*1")],
|
|
pools: [item(["name": "pool1", "ranges": "192.168.88.10-192.168.88.254"], id: "*2")],
|
|
dhcpServers: [], dhcpNetworks: [], dhcpClients: [],
|
|
routes: [item(["dst-address": "0.0.0.0/0", "gateway": "192.168.88.254"], id: "*3")],
|
|
filterRules: [item(["chain": "forward", "action": "drop"], id: "*4")],
|
|
natRules: [item(["chain": "srcnat", "action": "masquerade"], id: "*5")],
|
|
addressLists: [item(["list": "gesperrt", "address": "10.0.0.5"], id: "*6")]
|
|
)
|
|
|
|
let address = graph.nodes.first { $0.id == "IP-Adressen:192.168.88.1/24" }
|
|
XCTAssertEqual(address?.editTarget, OverviewNode.EditTarget(menuPath: "/ip address", restPath: "ip/address", itemID: "*1"))
|
|
|
|
let pool = graph.nodes.first { $0.id == "Pools & DHCP:pool:pool1" }
|
|
XCTAssertEqual(pool?.editTarget, OverviewNode.EditTarget(menuPath: "/ip pool", restPath: "ip/pool", itemID: "*2"))
|
|
|
|
let route = graph.nodes.first { $0.id == "route:0" }
|
|
XCTAssertEqual(route?.editTarget, OverviewNode.EditTarget(menuPath: "/ip route", restPath: "ip/route", itemID: "*3"))
|
|
|
|
let filter = graph.nodes.first { $0.id == "filter:0" }
|
|
XCTAssertEqual(filter?.editTarget, OverviewNode.EditTarget(menuPath: "/ip firewall filter", restPath: "ip/firewall/filter", itemID: "*4"))
|
|
|
|
let nat = graph.nodes.first { $0.id == "nat:0" }
|
|
XCTAssertEqual(nat?.editTarget, OverviewNode.EditTarget(menuPath: "/ip firewall nat", restPath: "ip/firewall/nat", itemID: "*5"))
|
|
|
|
// Address-list nodes fold multiple entries together — no single item to write back to.
|
|
let addressList = graph.nodes.first { $0.id == "Firewall & NAT:addrlist:gesperrt" }
|
|
XCTAssertNil(addressList?.editTarget)
|
|
}
|
|
}
|